add BaseAnalyzerArguments to keep ctor changes sane #939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also immediately makes tokens a part of it This struct can for example precompute token indices for line endings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also immediately makes tokens a part of it
This struct can for example precompute token indices for line endings.
I think this cleans up a little code debt and also allows automatic construction for most analyzers (not done in this PR) and with that also a cleaner way of introspecting configuration in the future for the INI config and passing it in through the constructor automatically.
The tokens array is available in each analyzer now, allowing to implement helper methods that operate with those, such as the diagnostic helpers.