fix wrong completion for if variable initialized with an array #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
ghost
requested a review
from 
WebFreak001
approved these changes
Dec 30, 2018
There was a problem hiding this comment.
I don't really like how this was fixed in the dsymbol API by disabling that addForeach parameter for this symbol (it seems like there is way more complexity in there than what it would really only need), but I guess with the added test it should at least stay working now, even on changes on that "foreach insertion hack".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suspect that the bug in dsymbol affected other more realistic cases than the one that had allowed to detect the problem so finally i decided to propagate the fix in dcd without waiting the next big change.