Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move dcd.common into separate subpackage #612

Merged
merged 1 commit into from
May 1, 2020

Conversation

WebFreak001
Copy link
Member

This allows external projects to depend on dcd:common, which is needed to embed DCD clients.

Previously depending on DCD from dub would cause the whole server to be fetched with it, and with that also the dependencies libdparse, dsymbol, etc. which could cause conflicts with packages wanting to use DCD.

This allows external projects to depend on dcd:common, which is needed
to embed DCD clients
@WebFreak001
Copy link
Member Author

WebFreak001 commented Apr 30, 2020

@LaurentTreguier just requested a review from you in case you have time for this. Might be interesting for you if you plan to restart dls some time, as this is a quite simple change but changes where the build files are for common. If you had any tools that used DCD as submodule instead of with dub, they will probably break with this

@WebFreak001 WebFreak001 requested a review from Hackerpilot April 30, 2020 13:12
@WebFreak001
Copy link
Member Author

in my project I'm seeing considerably performance improvements on Windows when using DCD through the dcd.common interface, without breaking my dependencies.

Basically would just need some feedback if the code breakage, when using DCD as a git submodule, is ok.

There should be no change to packages using DCD as a dub dependency (those who depend on dcd-server). I have tried compiling DLS with this change, which uses DCD directly, and it seems to build fine.

@LaurentTreguier
Copy link
Contributor

I haven't used DCD as a git submodule, and if I get back to DLS at some point, it might not even use the dlang-community tools; so this change is perfectly fine by me.
The breakage for git submodules means nothing more than a new minor release IMHO, just like other such changes

@dlang-bot dlang-bot merged commit f22b193 into dlang-community:master May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants