Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace stdx-allocator with std.experimental #672

Closed
wants to merge 2 commits into from
Closed

replace stdx-allocator with std.experimental #672

wants to merge 2 commits into from

Conversation

WebFreak001
Copy link
Member

No description provided.

@WebFreak001
Copy link
Member Author

@nordlow wanna review this?

@WebFreak001 WebFreak001 mentioned this pull request Jul 6, 2022
Merged
@WebFreak001
Copy link
Member Author

just realized this is a duplicate of #670

@nordlow you replaced the ASTAllocator everywhere, I used the allocatorObject here, reasons for your design decision?

@WebFreak001 WebFreak001 force-pushed the upgrade-stdx-allocator branch from ce08629 to c4e4d6f Compare July 9, 2022 17:12
@nordlow
Copy link
Contributor

nordlow commented Jul 14, 2022

Let me look into #670 again.

@nordlow nordlow mentioned this pull request Jul 14, 2022
Closed
@WebFreak001
Copy link
Member Author

the need to update dsymbol broke the tests here (but fixed those: dlang-community/dsymbol#183)

So closing this in favor of just directly both replacing all the std.experimental changes as well as integrating dsymbol with #673

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WebFreak001 @nordlow