-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port test.sh
to platform independent D.
#551
Conversation
Allow comments in selective imports. (dlang-community#403)
This script simply ignores differences in line ending, unless |
I am keeping this in draft for the moment because on Windows |
14659b7
to
8e33d12
Compare
I had it backwards yesterday night: the script should be correct in it's current state for the current I intentionally did not touch This should be ready for review now. |
This executes also way faster by not spawning GNU diff.
Seems OK to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it might make sense to force an --end_of_line parameter to all dfmt calls, so all files are always tested with the platform native EOL string (if not changed to anything else)
That will make tests fail for anyone that has configured Git to check out files with line endings that differ from what is native to the platform (apparently, such people exist). I think the suggestion made in #552 is better, because then tests are run in the same manner on every platform:
EDIT: well, not "in the same manner", that will depend on Git settings, but I mean the script will not special-case the platform if |
Co-authored-by: Jan Jurzitza <gh@webfreak.org>
Can we get this merged please? I have a PR for #552 ready that assumes this. |
Thanks, that was quick! |
This executes also way faster by not spawning GNU diff (at least on Windows).