Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI #560

Merged
merged 1 commit into from
Jul 14, 2022
Merged

CI #560

merged 1 commit into from
Jul 14, 2022

Conversation

veelo
Copy link
Contributor

@veelo veelo commented Jul 12, 2022

Add GitHub action.

Add GitHub action.
@veelo
Copy link
Contributor Author

veelo commented Jul 12, 2022

Copy link
Member

@WebFreak001 WebFreak001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this does not seem to be based on https://github.com/dlang-community/dfmt/blob/master/.travis.sh

I think it might be better to port the travis CI config as it currently does:

  • build dfmt both with minimum supported libdparse and maximum supported libdparse
  • test the makefile building
  • run the test.sh script

@veelo
Copy link
Contributor Author

veelo commented Jul 13, 2022

Indeed. But if it's already there, why isn't it in use? I don't really care how things are done, I just observed there was no CI.

  • run the test.sh script

That is Posix-only.

@rikkimax
Copy link
Contributor

Indeed. But if it's already there, why isn't it in use? I don't really care how things are done, I just observed there was no CI.

https://forum.dlang.org/post/sfueznovjwywbnzhptha@forum.dlang.org

@veelo
Copy link
Contributor Author

veelo commented Jul 13, 2022

I see.

Personally I am not planning on using more time on this, I think this PR is better than nothing, and can be extended to adopt more from .travis.sh by anyone who wants to. Whatever is decided, I do think it should use test.d as this PR does instead of test.sh, as test.d is platform independent and faster also.

I'll leave this PR open and see what happens, my main objective is to move forward with #553.

@rikkimax
Copy link
Contributor

I'm getting a bit annoyed with #561 so I think it may be best to get this in to unblock people moving forward even if it isn't quite as comprehensive or handling of releases.

@WebFreak001
Copy link
Member

ok sounds good, I guess the old files are there to be picked up again later as well

@WebFreak001 WebFreak001 merged commit 4947bee into dlang-community:master Jul 14, 2022
@veelo veelo deleted the ci branch July 14, 2022 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants