-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Symbol protection #139
Symbol protection #139
Conversation
@@ -215,6 +216,11 @@ struct Scope | |||
return getSymbolsByName(name); | |||
} | |||
|
|||
bool hasSymbolRecursive(const(DSymbol)* symbol) const |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not strictly part of the protection changes, I added it for the use-case of after checking protection in DCD
I don't think this is a very complex change, it just makes the protection available inside a @Basile-z what do you think? |
I'm struggling on what the other IDEs do. Lazarus do show private members. I don't remember what Delphi did, and otherwise I don't know. I think that this change was proposed by @CyberShadow initially. In other words, I wont be a decision maker here. |
for the dsymbol PR here I don't think any of that matters, it simply adds information about the visibility level of a symbol. I think this should be merged and a decision on hiding private members should be made on the DCD PR. |
tagged v0.7.0 since this modifies the API |
Moves protection into DSymbol
Needed for dlang-community/DCD#598