Fix 17351 - Manifest constants can't sometimes be passed by ref in CTFE

[Geod24]

As mentioned in the comment, the fix is crude but works well.

[dlang-bot]

Thanks for your pull request, @Geod24!

Bugzilla references

Auto-close	Bugzilla	Severity	Description
✓	17351	blocker	Static const array can't be evaluated at compile time when passed as ref argument

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + dmd#11545"

[thewilsonator]

Stable?

[Geod24]

Right, I guess I could do that :)

[Geod24]

Done

[UplinkCoder]

@thewilsonator @Geod24 give me a couple minutes to review this before slapping an auto-merge on.

[UplinkCoder]

@Geod24 please give it a fails complication tests which makes sure that modifications are impossible.

[Geod24]

@UplinkCoder : That's already covered by the type system, since the type is const or immutable. That's why I limited it to a test that ensures the right data is passed.

[UplinkCoder]

I am okay with this.

[Geod24]

So can this make the next patch release ?

[AndrejMitrovic]

LGTM.

[AndrejMitrovic]

I am okay with this.

Thanks. Let's go ahead with it I think.