Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bugzilla 24725 - core.sys.linux: feature detect glibc functions a… #16816

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

the-horo
Copy link
Contributor

…t build time.

This is just a sample implementation aimed to gather feedback before deciding on the final solution

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @the-horo! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
24725 enhancement core.sys.linux: feature detect glibc functions at build time

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#16816"

@the-horo the-horo force-pushed the druntime-bindings-features branch 6 times, most recently from 791fa08 to 3e9b899 Compare August 28, 2024 07:22
…t build time

Signed-off-by: Andrei Horodniceanu <a.horodniceanu@proton.me>
@the-horo the-horo marked this pull request as ready for review August 28, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants