cgxmm.d: add opcode_t #9324
Merged
cgxmm.d: add opcode_t #9324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalterBright
added
Review:Easy Review
Severity:Refactoring
|
Thanks for your pull request, @WalterBright! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + dmd#9324" |
thewilsonator
approved these changes
Feb 4, 2019
WalterBright
force-pushed
the
cgxmm_opcode
branch
from
44cb671 to
75f3665
Compare
WalterBright
added
the
Review:WIP
|
Can't see what I did wrong. Will have to do binary search. |
WalterBright
force-pushed
the
cgxmm_opcode
branch
8 times, most recently
from
4bd0c1a to
f28372f
Compare
WalterBright
force-pushed
the
cgxmm_opcode
branch
from
f28372f to
b4588fa
Compare
WalterBright
removed
the
Review:WIP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And fix conflation between
OPERandopcode_tinxmmeq(), and some wrongly typed variables.