Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

Add explicit @system attribute to extern functions #3112

Merged
merged 1 commit into from
May 23, 2020

Conversation

pbackus
Copy link
Contributor

@pbackus pbackus commented May 22, 2020

Needed for compatibility with @safe-by-default.


These @system-by-default function declarations were found using the deprecation message introduced in dlang/dmd#11176.

Needed for compatibility with @safe-by-default.
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @pbackus! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + druntime#3112"

@dlang-bot dlang-bot merged commit d11d392 into dlang:master May 23, 2020
@pbackus pbackus deleted the extern-safety branch May 24, 2020 17:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants