Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

Fix Issue 22454 - OpenBSD: Add prototypes for pthread_np.h #3605

Merged
merged 1 commit into from
Oct 30, 2021

Conversation

ibara
Copy link
Contributor

@ibara ibara commented Oct 30, 2021

No description provided.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @ibara! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
22454 enhancement OpenBSD: Add prototypes for pthread_np.h

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + druntime#3605"

@dlang-bot dlang-bot added the Enhancement New functionality label Oct 30, 2021
@ibara
Copy link
Contributor Author

ibara commented Oct 30, 2021

Spurious dlang-community/dfmt test error?

@nogc:

public import core.sys.posix.sys.types;
public import core.sys.posix.signal; // for stack_t
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other BSD variants don't publicly import this module; I guess non-publicly importing stack_t alone would be better wrt. consistent namespace pollution.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do plan to use this module in one place in druntime after this is committed.
I switched public import core.sys.posix.signal; // for stack_t to private import core.sys.posix.signal : stack_t; in a force push.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx - private is the default and so not needed; there are only half a dozen other occurrences of private import in druntime/Phobos, probably ancient.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright; I'll remove the private keyword. Thanks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Done)

@ibara ibara force-pushed the openbsd-pthread_np branch 2 times, most recently from dd743cc to 1d31c14 Compare October 30, 2021 16:52
@ibara ibara force-pushed the openbsd-pthread_np branch from 1d31c14 to 420efc9 Compare October 30, 2021 16:59
@kinke kinke merged commit 19f07f9 into dlang:stable Oct 30, 2021
@kinke
Copy link
Contributor

kinke commented Oct 30, 2021

[Wrt. dfmt, that's totally unrelated, see https://github.com/dlang-community/dfmt/pull/544.]

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Enhancement New functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants