-
-
Notifications
You must be signed in to change notification settings - Fork 421
Fix Issue 22454 - OpenBSD: Add prototypes for pthread_np.h #3605
Conversation
Thanks for your pull request and interest in making D better, @ibara! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "stable + druntime#3605" |
Spurious |
src/core/sys/openbsd/pthread_np.d
Outdated
@nogc: | ||
|
||
public import core.sys.posix.sys.types; | ||
public import core.sys.posix.signal; // for stack_t |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other BSD variants don't publicly import this module; I guess non-publicly importing stack_t
alone would be better wrt. consistent namespace pollution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do plan to use this module in one place in druntime after this is committed.
I switched public import core.sys.posix.signal; // for stack_t
to private import core.sys.posix.signal : stack_t;
in a force push.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx - private
is the default and so not needed; there are only half a dozen other occurrences of private import
in druntime/Phobos, probably ancient.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright; I'll remove the private keyword. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Done)
dd743cc
to
1d31c14
Compare
1d31c14
to
420efc9
Compare
[Wrt. dfmt, that's totally unrelated, see https://github.com/dlang-community/dfmt/pull/544.] |
No description provided.