Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pr_info GitHub actions run #2586

Merged
merged 1 commit into from
Mar 9, 2023
Merged

Conversation

WebFreak001
Copy link
Member

@WebFreak001 WebFreak001 commented Feb 10, 2023

Gives summary about some basic statistics, deprecations and warnings.

The added action will fail here because it's a PR that's adding an action and the action needs access to the GITHUB_TOKEN to post comments on issues

Sample output: WebFreak001#1

runs-on: ubuntu-20.04
steps:
- name: 'Prepare sticky comment'
uses: marocchino/sticky-pull-request-comment@v2
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we use an exact commit / version with this action or trust on them not introducing malicious content?

I think an exact commit would be more secure.

(2 occurrences of this)

@rikkimax
Copy link
Contributor

rikkimax commented Mar 2, 2023

It looks like there is some sort of permission problem and hence isn't running right now, so not currently mergeable until someone with admin privileges fixes it (I think).

@WebFreak001
Copy link
Member Author

no, the problem is that I PRd from my repository, which has a different access token - so the comment action fails to run here because running modified CI scripts in the security context of the target repository would just be broken.

It will start working once merged, see the linked PR

@rikkimax
Copy link
Contributor

rikkimax commented Mar 2, 2023

Okay looks good +1

Gives summary about some basic statistics, deprecations and warnings
@WebFreak001 WebFreak001 merged commit 3ea6bbe into dlang:master Mar 9, 2023
@WebFreak001 WebFreak001 deleted the pr_info branch March 9, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants