Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up module parsing with hand-written parser #2897

Merged
merged 5 commits into from
Apr 22, 2024

Conversation

atilaneves
Copy link
Contributor

In one project at work it reduced the time to create the test configuration from 80ms to 40ms. This new vesion also passes a unit test that the old version did not.

Copy link

github-actions bot commented Apr 11, 2024

✅ PR OK, no changes in deprecations or warnings

Total deprecations: 0

Total warnings: 0

Build statistics:

 statistics (-before, +after)
-executable size=5347800 bin/dub
-rough build time=63s
+executable size=5343768 bin/dub
+rough build time=64s
Full build output
DUB version 1.36.0, built on Mar  3 2024
LDC - the LLVM D compiler (1.37.0):
  based on DMD v2.107.1 and LLVM 17.0.6
  built with LDC - the LLVM D compiler (1.37.0)
  Default target: x86_64-unknown-linux-gnu
  Host CPU: znver3
  http://dlang.org - http://wiki.dlang.org/LDC


  Registered Targets:
    aarch64     - AArch64 (little endian)
    aarch64_32  - AArch64 (little endian ILP32)
    aarch64_be  - AArch64 (big endian)
    amdgcn      - AMD GCN GPUs
    arm         - ARM
    arm64       - ARM64 (little endian)
    arm64_32    - ARM64 (little endian ILP32)
    armeb       - ARM (big endian)
    avr         - Atmel AVR Microcontroller
    bpf         - BPF (host endian)
    bpfeb       - BPF (big endian)
    bpfel       - BPF (little endian)
    hexagon     - Hexagon
    lanai       - Lanai
    loongarch32 - 32-bit LoongArch
    loongarch64 - 64-bit LoongArch
    mips        - MIPS (32-bit big endian)
    mips64      - MIPS (64-bit big endian)
    mips64el    - MIPS (64-bit little endian)
    mipsel      - MIPS (32-bit little endian)
    msp430      - MSP430 [experimental]
    nvptx       - NVIDIA PTX 32-bit
    nvptx64     - NVIDIA PTX 64-bit
    ppc32       - PowerPC 32
    ppc32le     - PowerPC 32 LE
    ppc64       - PowerPC 64
    ppc64le     - PowerPC 64 LE
    r600        - AMD GPUs HD2XXX-HD6XXX
    riscv32     - 32-bit RISC-V
    riscv64     - 64-bit RISC-V
    sparc       - Sparc
    sparcel     - Sparc LE
    sparcv9     - Sparc V9
    spirv32     - SPIR-V 32-bit
    spirv64     - SPIR-V 64-bit
    systemz     - SystemZ
    thumb       - Thumb
    thumbeb     - Thumb (big endian)
    ve          - VE
    wasm32      - WebAssembly 32-bit
    wasm64      - WebAssembly 64-bit
    x86         - 32-bit X86: Pentium-Pro and above
    x86-64      - 64-bit X86: EM64T and AMD64
    xcore       - XCore
   Upgrading project in /home/runner/work/dub/dub/
    Starting Performing "release" build using /opt/hostedtoolcache/dc/ldc2-1.37.0/x64/ldc2-1.37.0-linux-x86_64/bin/ldc2 for x86_64.
    Building dub 1.37.0-rc.1+commit.17.g33cdfa1d: building configuration [application]
     Linking dub
STAT:statistics (-before, +after)
STAT:executable size=5343768 bin/dub
STAT:rough build time=64s

@atilaneves atilaneves requested a review from Geod24 April 11, 2024 18:54
Copy link
Contributor

@rikkimax rikkimax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As is this won't work due to identifier character sets. See comment for potential solution.

source/dub/internal/utils.d Outdated Show resolved Hide resolved
source/dub/internal/utils.d Outdated Show resolved Hide resolved
source/dub/internal/utils.d Outdated Show resolved Hide resolved
@atilaneves
Copy link
Contributor Author

TIL that \w in D does things it doesn't in Perl.

source/dub/internal/utils.d Outdated Show resolved Hide resolved
source/dub/internal/utils.d Show resolved Hide resolved
@atilaneves atilaneves dismissed WebFreak001’s stale review April 19, 2024 18:42

I've already made the changes.

@atilaneves atilaneves merged commit d767532 into dlang:master Apr 22, 2024
31 checks passed
@atilaneves atilaneves deleted the parse-module branch April 23, 2024 13:57
@kinke
Copy link
Contributor

kinke commented May 31, 2024

This fails/regressed (parses s.foo):

assert(getModuleNameFromContent("module modules.foo;") == "modules.foo");

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants