馃弮 Refactor healthcheck logic into new package #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chuckha
force-pushed
the
control-plane-scale-serially
branch
from
cb49e6c
to
77e913c
Compare
chuckha
commented
Feb 6, 2020
chuckha
force-pushed
the
control-plane-scale-serially
branch
3 times, most recently
from
bbe1bf8
to
1a496d3
Compare
chuckha
commented
Feb 6, 2020
| @@ -1,5 +1,5 @@ | |||
| /* | |||
| Copyright The Kubernetes Authors. | |||
| Copyright 2020 The Kubernetes Authors. | |||
There was a problem hiding this comment.
Necessary for make verify to pass
| @@ -1,9 +1,12 @@ | |||
| /* | |||
| Copyright 2020 The Kubernetes Authors. | |||
|
|
|||
There was a problem hiding this comment.
Necessary for make verify to pass
| @@ -1,3 +1,19 @@ | |||
| /* | |||
|
Apart from my response to the open question, lgtm. Really nice refactor! |
dlipovetsky
reviewed
Feb 6, 2020
dlipovetsky
reviewed
Feb 6, 2020
chuckha
force-pushed
the
control-plane-scale-serially
branch
from
1a496d3
to
0320c9c
Compare
Signed-off-by: Chuck Ha <chuckh@vmware.com>
chuckha
force-pushed
the
control-plane-scale-serially
branch
from
0320c9c
to
26e7b3b
Compare
dlipovetsky
pushed a commit
that referenced
this pull request
Aug 21, 2022
[D2IQ-88840] check on hash values before committing changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chuck Ha chuckh@vmware.com
What this PR does / why we need it:
This PR consolidates some of the logic found int he reconciler into a ManagementCluster idea and Cluster idea. The attempt is to keep logic out of the reconciler. This will aid in unit testing as well as reconciler readability.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Related to kubernetes-sigs#2016
cc @detiber @randomvariable