Avoid pulling core::fmt for PackingError when unwrapping #76
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my comment I said that all the
fmt
was being pulled due to my application code, but I actually didn't notice that I was testing with slight modifications tousbd-human-interface-device
. I reviewed my changes and it looks likefmt
was being pulled due to.pack().expect(...)
(besides my unwrapping ofUsbHidError
).This PR fixes the problem by dropping the
PackingError
before callingexpect
. I also included a minor fix that avoids hex formatting in onepanic!
. I think that the fixed-string message should give enough context (you could addlog::error!
if more context is needed).