Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed sourcemaps with different file.base #314

Merged
merged 1 commit into from
Jul 14, 2015
Merged

Fixed sourcemaps with different file.base #314

merged 1 commit into from
Jul 14, 2015

Conversation

TrySound
Copy link
Contributor

Hi! Use sass and autoprefixer together on work. Need to fix ASAP.
Thanks!

@ai
Copy link

ai commented Jul 12, 2015

BTW, file.path.split('/').pop() is bad for Windows too

@ai
Copy link

ai commented Jul 12, 2015

/cc @Snugug

@Snugug
Copy link
Collaborator

Snugug commented Jul 14, 2015

@TrySound does this resolve the three linked issues?

Snugug added a commit that referenced this pull request Jul 14, 2015
Fixed sourcemaps with different file.base
@Snugug Snugug merged commit 2b0f446 into dlmanning:master Jul 14, 2015
@TrySound
Copy link
Contributor Author

@Snugug Just #276 and maybe #276

@Snugug
Copy link
Collaborator

Snugug commented Jul 14, 2015

@TrySound #296 you mean?

@TrySound
Copy link
Contributor Author

@Snugug Yes. #296 resolved.

@Snugug
Copy link
Collaborator

Snugug commented Jul 14, 2015

👍

@Snugug
Copy link
Collaborator

Snugug commented Jul 14, 2015

Thank you for the PR!

@TrySound
Copy link
Contributor Author

@Snugug Mapping still wrong. But I don't think it's gulp-sass's issue.

@TrySound
Copy link
Contributor Author

@Snugug Don't forget to release and npm publish, please.

@Snugug
Copy link
Collaborator

Snugug commented Jul 14, 2015

Yup. Looking at the rest of the open PRs before I publish. It'll be in the next few hours.

@TrySound
Copy link
Contributor Author

@Snugug you promised release.

@Snugug
Copy link
Collaborator

Snugug commented Jul 15, 2015

2.0.4 released.

@TrySound
Copy link
Contributor Author

@Snugug Thanks!

@MaciejJanyska
Copy link

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants