Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update error handling and handled partials #9

Merged
merged 1 commit into from
Jan 10, 2014

Conversation

neilkinnish
Copy link
Contributor

  1. Updated so as an error is logged rather than reported as an error as this will stop the watcher which could be annoying - although may be a preference option?
  2. Added logic to ignore a partial (doesn't log) essentially a sass file prefixed with '_'

1. Updated so as an error is logged rather than reported as an error as this will stop the watcher which could be annoying - although may be a preference option?

2. Added logic to ignore a partial (doesn't log) essentially a sass file prefixed with '_'
@neilkinnish
Copy link
Contributor Author

Thanks for the merge - just one thing I noticed the errors are allowed to bubble back up which causes the file watcher to stop, is this intended?

It's easy to make a mistake and quickly rectify when writing Sass and if the watcher constantly stops it can be painful, I personally prefer it to just log the error to the console and continue, but understand this is preference.

Can an option be added at least so as it's up to the user?

@dlmanning
Copy link
Owner

I see your point. I'll look at adding an option.

@dlmanning
Copy link
Owner

For you: db43de3

@neilkinnish
Copy link
Contributor Author

Thats great - thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants