Skip to content

Commit

Permalink
Only make a PVC for a PipelineRun if we need to. 🗑️
Browse files Browse the repository at this point in the history
We only need to make a PVC if a Pipeline contains tasks that declare Output
resources of the allowed types. This PR changges our detection to only create
a PVC under those conditions.

This was originally attempted in tektoncd#1007 and
then subsequently rolled back in tektoncd#1071. I
*think* this one gets the logic correct :)

Co-authored-by: Christie Wilson <bobcatfish@gmail.com>
Fixes: tektoncd#937
  • Loading branch information
dlorenc and bobcatfish committed Nov 8, 2019
1 parent 6d2fbac commit c25d6a3
Show file tree
Hide file tree
Showing 8 changed files with 361 additions and 79 deletions.
7 changes: 7 additions & 0 deletions pkg/apis/pipeline/v1alpha1/resource_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,13 @@ import (
// additional metatdata should be provided for it.
type PipelineResourceType string

var (
AllowedOutputResources = map[PipelineResourceType]bool{
PipelineResourceTypeStorage: true,
PipelineResourceTypeGit: true,
}
)

const (
// PipelineResourceTypeGit indicates that this source is a GitHub repo.
PipelineResourceTypeGit PipelineResourceType = "git"
Expand Down
Loading

0 comments on commit c25d6a3

Please sign in to comment.