Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect track titles with Spotify #101

Closed
SetianKing opened this issue Apr 24, 2016 · 21 comments
Closed

Incorrect track titles with Spotify #101

SetianKing opened this issue Apr 24, 2016 · 21 comments
Assignees
@dlrudie
Labels
enhancement

Comments

@SetianKing
Copy link

I just downloaded Snip and love it. However, I noticed that sometimes it will display incorrect song titles. Artist will be correct, just the song title will be wrong. Only happened twice so far.
@murko69
Copy link
Contributor

murko69 commented Jun 23, 2016 •
edited
Loading

Actually happens to me more than just twice.
I get this several times per week (as I notice) and I run Spotify very often.
The wrong track name is often another track from the same album
I spotted it just now and had time to make a screen dump of both spotify and the actual output on a web page.

link to screenshot: http://easycaptures.com/fs/uploaded/975/6711461992.jpg

@dlrudie
Copy link
Owner

dlrudie commented Jun 28, 2016

I wonder if it happens on tracks where the track title is the same as the album title. It may get confused as to which track is actually playing.

@SetianKing
Copy link
Author

I thought about that, but it was happening on albums that didn't have
tracks that were the same as the album title.
On Jun 27, 2016 6:52 PM, "David Rudie" notifications@github.com wrote:

I wonder if it happens on tracks where the track title is the same as the
album title. It may get confused as to which track is actually playing.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#101 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/ARxqVXS3KnMdt-wrMq39gVU1IPbkiYsZks5qQHBjgaJpZM4IOWgf
.

@murko69
Copy link
Contributor

murko69 commented Jun 28, 2016

In my experience (the few times I actually paid attention to this =)) you are spot on dlrudie, but since SetianKing says otherwise I ca't really swear on it :D

@SetianKing
Copy link
Author

I did notice what dlrudie mentioned as well, but it also happens when there
is no track that matches the album title. I don't use Snip anymore, so I
can't go and look at what ither albums it happened on.
On Jun 28, 2016 8:46 AM, "murko69" notifications@github.com wrote:

In my experience (the few times I actually paid attention to this =)) you
are spot on dlrudie, but since SetianKing says otherwise I ca't really
swear on it :D

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#101 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/ARxqVRKUmSLLUsm0_pSbYQFFT7IUUrJWks5qQTPOgaJpZM4IOWgf
.

@Jimsnipe
Copy link

This also seems to be happening with songs that have unicode characters in the titles. http://i.imgur.com/SXsVtuZ.png when the actual song is ミドリ - お猿

@SetianKing
Copy link
Author

A streamer I watch uses Snip, and I've noticed, that as was stated before,
if the album has a title track, then it does indeed come up with an
incorrect song title.
On Jul 19, 2016 6:29 AM, "Jimsnipe" notifications@github.com wrote:

This also seems to be happening with songs that have unicode characters in
the titles. http://i.imgur.com/SXsVtuZ.png when the actual song is ミドリ -
お猿

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#101 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ARxqVd4vwecacXuNSzwC0ak0fTFuJk4qks5qXMMcgaJpZM4IOWgf
.

@dlrudie
Copy link
Owner

dlrudie commented Jul 19, 2016

I've been quite busy lately. I apologize for a delay in solutions. I'll be returning to Snip soon and will look into a solution to fix this.

Jimsnipe, can you link to the Spotify URL for that song?

@ghost
Copy link

ghost commented Aug 16, 2016

I've only very seldom encountered instances of the song title being wrong. One such is this song here: https://open.spotify.com/track/7AK0d1Qp3XAxFwM9GRIDER - Spotify lists the song as "Turn Your Back" but Snip is titling it "Turn Your Back w/ Anti-Flag". Minor issue, but not sure why it happens and presumably it could happen in other instances.

One problem I have much more frequently is some songs that just seem to not provide any data. There are several dozen songs among my playlists where Snip will just continue to display the info for the song before it. Some songs that I've had this issue with:

So for example if I played a song that works and then played the above 6 songs in a row, it would show the information from the first song that entire time.

These are all from the same album (although some songs from the album work properly), but I've had the issue with songs from several other artists and albums too (can't recall which ones off the top of my head, but if you'd like I can scrounge around for more examples).

@murko69
Copy link
Contributor

murko69 commented Aug 16, 2016 •
edited
Loading

I also have these issues on this particular album that Erik shows. Also
the tracks that work are listed as album name "HITS" but the album name
should really be "Dead Silence". So I'm guessing Snip always think these
songs are from the album HITS and therefor only the ones that actually
are, works.

If I hover the Snip-icon in the system field (or whatever it's called)
the correct "title-artist" is shown, hence the file Snip.txt is correct.
This only happens with the separate info so I'm guessing the problem
here is really the false album info even though this is a bit different from the actual thread issue I guess.

Den 2016-08-16 kl. 08:53, skrev Erik:

I've only very seldom encountered instances of the song title being
wrong. One such is this song here:
https://open.spotify.com/track/7AK0d1Qp3XAxFwM9GRIDER - Spotify lists
the song as "Turn Your Back" but Snip is titling it "Turn Your Back w/
Anti-Flag". Minor issue, but not sure why it happens and presumably it
could happen in other instances.

One problem I have much more frequently is some songs that just seem
to not provide any data. There are several dozen songs among my
playlists where Snip will just continue to display the info for the
song before it. Some songs that I've had this issue with:

So for example if I played a song that works and then played the above
6 songs in a row, it would show the information from the first song
that entire time.

These are all from the same album (although some songs from the album
work properly), but I've had the issue with songs from several other
artists and albums too (can't recall which ones off the top of my
head, but if you'd like I can scrounge around for more examples).

@ghost
Copy link

ghost commented Aug 16, 2016

The problem persists for me even when the information is just saved in one file - it ignores my formatting (separator, spaces, etc.) and shows things out of order.

When the file output is configured to be "$t$a" (SongnameArtist), a song that works ordinarily will show up in this format. e.g. Viking Death MarchBilly Talent. Meanwhile the songs that produced the problem described previously show up in the format "$a - $t" (Artist - Title). They will be displayed in this format even if I remove Artist information etc. So it seems on songs where it's not grabbing the metadata it just lists the title as whatever the Spotify window is called based on what's playing.

@tterrag1098
Copy link

I have found the bug in the source code...a rather silly bug really.

It seems to be assumed that the first search result will be the correct song, when this is not always the case (see https://github.com/dlrudie/Snip/blob/master/Snip/Players/Spotify.cs#L87-L89).

Could be easily fixed by iterating over the results and comparing the titles for equality, as the Spotify window title can easily be split into artist - track.

However, dev on this project seems to be dead, and I have no knowledge of how to compile a C# project. If anyone wants to correct the source, and rebuild, I would be very grateful as this bug is particularly annoying for a few of the songs in my library.

@dlrudie
Copy link
Owner

dlrudie commented Aug 18, 2016 •
edited
Loading

I'm definitely not dead; I'm just busy. It's not really a bug. It just wasn't wrote to iterate over the results.

Also, that's not as easy to split as you might think. There are many song titles and artists that also have a hyphen in their name. This makes splitting it difficult.

In the past Spotify would use an en dash (—) but in one of their updates it switched to a regular hyphen (-). I used to split it with the en dash but can't anymore, so I just feed the whole string to Spotify.

Whenever I have time I do have a bunch of changes and fixes I want to make. The project is not dead; time is just limited.

@murko69
Copy link
Contributor

murko69 commented Aug 18, 2016 •
edited
Loading

I really don't think the project nor the dev is dead, I'm guessing he
just got other things on his plate as well. A-life-on-the-side you know :)

EDIT: I was too late =)

Den 2016-08-18 kl. 11:56, skrev tterrag:

I have found the bug in the source code...a rather silly bug really.

It seems to be assumed that the first search result will be the
correct song, when this is not always the case (see
https://github.com/dlrudie/Snip/blob/master/Snip/Players/Spotify.cs#L87-L89).

Could be easily fixed by iterating over the results and comparing the
titles for equality, as the Spotify window title can easily be split
into |artist - track|.

However, dev on this project seems to be dead, and I have no knowledge
of how to compile a C# project. If anyone wants to correct the source,
and rebuild, I would be very grateful as this bug is particularly
annoying for a few of the songs in my library.

@tterrag1098
Copy link

@dlrudie Well that's great to hear! I just noticed the lack of commits lately and assumed the worst. I'm happy to see that's not the case.

Could you not do something like spotifyTitle.contains(json[i].title) && spotifyTitle.contains(json[i].artist) ? That to me sounds like it would cover most of the cases.

@tterrag1098
Copy link

Of course, the proper solution (as I see it) would be to make a real spotify web app with OAuth and access the user's account to see what they are playing. My above solution (I think) could be a decent stopgap, but I think this should be considered.

tterrag1098 added a commit to tterrag1098/Snip that referenced this issue Aug 18, 2016
@tterrag1098
Fix dlrudie#101 incorrect track titles with Spotify
053e2be 
Now iterates over all the search returns and makes sure
that the window title contains the song/artist before
using it as the current song.
@tterrag1098
Copy link

I have implemented my proposed stopgap solution and it seems to work fine. PR #112

@dlrudie
Copy link
Owner

dlrudie commented Aug 19, 2016

Thanks. I hope to go over this issue and a bunch of other issues soon. I've been watching the issues here (even though I've been quiet) and taking notes.

I appreciate the support and will return to Snip very soon.

In the meantime, Deschutes Fresh Squeezed IPA is pretty amazing.

@dlrudie dlrudie self-assigned this Aug 19, 2016
@tterrag1098
Copy link

Awesome! Glad to see such a neat project getting some more love. In the meantime, I will probably just use my PR from source, for my streaming needs 😄.

@dlrudie
Copy link
Owner

dlrudie commented Aug 19, 2016

That's why this is here on GitHub. Anyone can take the source and fix it, implement features, change things, tailor it to their own needs, etc. I know that I won't always be around and that shouldn't hinder what Snip is or what it could be.

@dlrudie
Copy link
Owner

dlrudie commented Sep 4, 2016

So I found a little bit of free time this weekend and dug into this some more.

It appears there's a popularity value in the results. I think sorting the results by popularity and choosing the one with the highest value will lead to more accurate results.

I'm going to implement that and see how it works out. I'm also going to rewrite album artwork handling to better match the results as well.

@dlrudie dlrudie closed this as completed in 618a7aa Sep 4, 2016
dlrudie pushed a commit that referenced this issue Sep 4, 2016
Fixes song title selection if album has same name
086f22d 
When querying Spotify's servers in the past to get the track information
I would use the first result returned. However, if the song title is
also the title of the album then the song title returned may actually be
another track off of that same album. This is also a fix for #101 as
there were multiple concerns within the same issue.

Thanks to tterrag1098 for the suggestion of comparing the window title
to the track artist and track title. This will ensure that the result is
correct.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dlrudie dlrudie

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@dlrudie @tterrag1098 @murko69 @SetianKing @Jimsnipe