-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5.3.0 - Invalid JSON string w/ Spotify #87
Comments
Just a quick note too.. If I close spotify and run Snip, it loads just fine. The moment I play a track, it crashes again with the same error. |
Can you post your Spotify version? Mine has not asked me to update to any newer version and it's still working for me. |
Just chiming in that I'm having the exact same issue, same version of Spotify |
Try this file and screenshot any error boxes that pop up. |
I have not been able to duplicate this issue. |
Is there anything that we can do to assist in determining the cause?
|
Sorry, didn't see that.I'll try it tomorrow when I'm home. Thanks again! |
Using the file you linked, I'm able to use it with Spotify on stream flawlessly. |
That's weird. I literally changed nothing other than added one try-catch exception to display a messagebox instead of crashing. |
I am still getting this error as well, with the one try-catch exception added, I receive a ton of messages boxes that are near endless until I quit snip. |
You probably will. What do they look like? |
It looks like you can't access Spotify's web server. I can't either right now. They might be doing some maintenance or something. |
Fair enough. Will keep you updated if it continues past the next few hours. You need a packet trace or anything? EDIT: If it does continue, I mean do you need a packet trace. |
For the record, the 503 Server Unavailable error is different than the original issue. The original issue is about invalid JSON, not server unavailability. If you can re-test to see if you can duplicate the issue that would be great. In the meantime I think I'll use this issue to implement better error catching and fall-backs. |
@dlrudie Sorry for the delay in testing. Your test files work just fine. I confirmed the current release is still giving me the same error. |
I still have no answer for this. |
I solved the issue with the version you provided just above, but my antivirus (BitDefender) says that it's a virus. |
I'm still experiencing this issue, however its extremely intermittent. |
I have too this problem and link dlrudie send I no can open this snip in my PC |
Looks like when it tries to parse the JSON, it doesn't know how to handle null or empty data. It looks like it was coming from Spotify.cs at Line 76, There's not a check to see if the download is null or empty, thus causing that error. I'm testing your source in one of my development projects, and that particular line got brought to my attention. I hope this helps you. |
There are definitely some bugs in regards to this. Most noticeably is when Spotify's site simply does not provide the JSON to you. I've ran into this randomly where I'll request the JSON from their site and it will simply reply with a blank result. When I submit it a second time exactly the same way it returns successfully. While I have never seen this issue with my own use of Snip... I can see where it could potentially happen to some users if, for example, Spotify throttles responses to users within a broad IP range. Snip could definitely use better error handling and I do intend to implement just that in the future. |
Hello, thought i'd leave a comment regarding this issue.. This exception is still occurring in Snip v5.5.0 with Spotify version 1.0.38.171.g5e1cd7b2 https://open.spotify.com/track/3vZO25GdYuqFrR1kzZADnp It occurs whether i rapidly skip through playlists or not, so it's not a rate-limit issue or the like from Spotify. Cheers for Snip! |
Great! As soon as I get off of work today I'll take a look at it. Thank you. |
While researching #87 I found that Snip would repeatedly spam Spotify's server until it got a result. This allows only one query to occur at a time.
Hello. Spotify updated and ever since then I'm getting this error message.
The text was updated successfully, but these errors were encountered: