remove explicit isort from precommit as its behavior is included in ruff

dlstadther · Oct 18, 2023 · cbdd5b9 · cbdd5b9
1 parent 4e1fa10
commit cbdd5b9
Show file tree

Hide file tree

Showing 4 changed files with 55 additions and 93 deletions.
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -29,12 +29,6 @@ repos:
   hooks:
     - id: ruff
 
-# isort
-- repo: https://github.com/pycqa/isort
-  rev: 5.11.5
-  hooks:
-    - id: isort
-
 # mypy
 - repo: https://github.com/pre-commit/mirrors-mypy
   rev: v1.1.1

diff --git a/README.md b/README.md
@@ -97,7 +97,6 @@ The checks contained in this repo include (in the order in which they run):
 * Various checkers and formatters to verify valid file types, file size, and end of line and end of file whitespace/newlines
 * The `black` formatter will apply a standard code style format
 * `ruff` checks code for "lint"
-* `isort` reorders imports into a common format and order
 * `mypy` is used for static type checking
 * `poetry` checks on valid and aligned pyproject.toml and poetry.lock files
 * `sqlfluff` checks and fixes sql formatting and linting

diff --git a/poetry.lock b/poetry.lock
diff --git a/pyproject.toml b/pyproject.toml
@@ -27,7 +27,6 @@ python = "^3.9"
 [tool.poetry.group.dev.dependencies]
 black = "^23.9.1"
 coverage = {extras = ["toml"], version = "^7.3.2"}
-isort = "^5.12.0"
 mkdocs = "^1.5.3"
 mkdocs-material = "^9.4.5"
 mkdocstrings = {extras = ["python"], version = "^0.23.0"}
@@ -77,15 +76,6 @@ omit = [".*", "*/site-packages/*"]
 fail_under = 70
 
 
-#######
-# isort
-#######
-[tool.isort]
-profile = "black"
-line_length = 160
-filter_files = true
-
-
 ######
 # Mypy
 ######