Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heet result combination update #292

Merged
merged 3 commits into from
Oct 11, 2023
Merged

Conversation

heetrojivadiya
Copy link
Member

@heetrojivadiya heetrojivadiya commented Oct 10, 2023

Description

I have added additional parameter for result combination items with parenthesis. Also, I added unittest for the same.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Unit Tests
  • Attached examples

Test Configuration:

  • RFEM / RSTAB version: RFEM 6.04.0002
  • Python version: 3.11

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

resCom = Model.clientModel.service.get_result_combination(1)

assert resCom.no == 1
assert resCom.name == '(LC1 or 1.10 * LC2) + 2.00 * (1.50 * LC3 or 1.80 * LC4)'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
The second assert results for me in an error. If I take out all parenthesis and the 2.00, it is passing.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, I was getting same problem of parenthesis. I believe that it is due to pip package of RFEM.

@OndraMichal OndraMichal merged commit f4ac894 into main Oct 11, 2023
1 of 2 checks passed
@OndraMichal OndraMichal deleted the heet-resultCombinationUpdate branch October 11, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants