-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create CalculateInCloud function #319
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
it would be great to have complete test or example to be able to test the function. Parameters seems straight forward but I'm sure the prerequisites are not. It would be handy to have detailed description in docstring and if extensive then move it to Github Wiki and paste the url.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small improvement
RFEM/initModel.py
Outdated
cloudCalculationResult = model.clientModel.service.calculate_all_in_cloud(machine_id, run_plausibility_check, calculate_despite_warnings_and_errors, email_notification) | ||
print("Cloud calculation was started.") | ||
return cloudCalculationResult # list | ||
except: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better to not use bare exception here. I don't know which exact exception is here, but you should replace it with something like:
except ExceptionName:
...
This is handy because in bare try except, any raised exception is caught in the except, which is not ideal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added an example to the example folder and a specific exception.
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
Design Situation and Combination Wizard tests update by @OndraMichal in dlubal-software/RFEM_Python_Client#317 Create CalculateInCloud function by @Rebecca-Coding21 in dlubal-software/RFEM_Python_Client#319 BUG: Missing definition of modelLst in init.Model.py by @jarabroz in dlubal-software/RFEM_Python_Client#324 Action and Action Combination by @OndraMichal in dlubal-software/RFEM_Python_Client#320 Heet aluminum design by @heetrojivadiya in dlubal-software/RFEM_Python_Client#325 VasStach concrete bridge example by @VasStach in dlubal-software/RFEM_Python_Client#326 unit tests: 141 passed, 5 skipped in 423.77s (0:07:03) RSTAB: 9.05.0004.232.9b37bf15c09
Description
I added a function to initModel.py which starts the cloud calculation for a model.
Type of change
How Has This Been Tested?
I tested the new function with the attached script test.py and two different RFEM-models, one that creates plausibility errors and one that doesn't.
CalculateInCloudTest.zip
Test Configuration:
Checklist: