Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heet member spring #363

Merged
merged 6 commits into from
May 10, 2024
Merged

Heet member spring #363

merged 6 commits into from
May 10, 2024

Conversation

heetrojivadiya
Copy link
Member

@heetrojivadiya heetrojivadiya commented May 7, 2024

Description

created memberSpring.py and updated member.py with new staticmethod Spring()

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Unit Tests
  • Attached examples

Test Configuration:

  • RFEM / RSTAB version: RFEM 6.06.0006
  • Python version: 3.11

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@OndraMichal OndraMichal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both tests are failing!
suds.TypeNotFound: Type not found: 'member_type_spring'

@heetrojivadiya
Copy link
Member Author

both tests are failing! suds.TypeNotFound: Type not found: 'member_type_spring'

Hey, I have tested again and both tests are working fine with RFEM 6.06.0006.

image
image

Copy link
Contributor

@Rebecca-Coding21 Rebecca-Coding21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests are passing.

@OndraMichal OndraMichal merged commit c0dd8d5 into main May 10, 2024
1 of 2 checks passed
@OndraMichal OndraMichal deleted the heet-memberSpring branch May 10, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants