Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

303 request results table manager #370

Merged
merged 15 commits into from
Jun 4, 2024

Conversation

TomasPail
Copy link

@TomasPail TomasPail commented May 23, 2024

Description

Updates related to main change in Webservice core about unification of getting results using object_locations approach between results from FEM analysis and design addons. Python HLF API is not changed for the user at all, but there is broken backward compatibility (needed new RFEM version).

Beside that following issues are solved as well:

  • added object number into output structure of all tables from static analysis to ensure traceability between a result and the object, where result is located
  • newly respect result table manager settings to get filtered result tables with only selected result magnitudes
  • solve issues when getting results for selected object returns all results instead of just specifically for this member

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

By existing unit test for results which was extended (test_ResultTables.py)

  • Unit Tests
  • Attached examples

Test Configuration:

  • RFEM version: 6.06.0009.230.20104957326
  • Python version: 3.12.0

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@TomasPail TomasPail linked an issue May 23, 2024 that may be closed by this pull request
RFEM/Results/resultTables.py Outdated Show resolved Hide resolved
RFEM/Results/resultTables.py Outdated Show resolved Hide resolved
RFEM/Results/resultTables.py Show resolved Hide resolved
UnitTests/test_ResultTables.py Outdated Show resolved Hide resolved
UnitTests/test_ResultTables.py Outdated Show resolved Hide resolved
Copy link
Contributor

@OndraMichal OndraMichal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RFEM ver. 6.06.0009.230.20104957326
232 passed, 5 skipped in 608.91s (0:10:08)

unit tests: 232 passed, 5 skipped in 591.84s (0:09:51)
@OndraMichal OndraMichal merged commit a7e25a4 into main Jun 4, 2024
1 of 2 checks passed
@OndraMichal OndraMichal deleted the 303-request-results-table-manager branch June 4, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

REQUEST: Results Table Manager
2 participants