Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heet surface results adjustment #380

Merged
merged 4 commits into from
Jun 17, 2024
Merged

Conversation

heetrojivadiya
Copy link
Member

@heetrojivadiya heetrojivadiya commented Jun 11, 2024

Description

I updated surfaceResultsAdjustment.py for adjustment type 'USER_DEFINED' and 'ZERO' also updated unittest for it.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Unit Tests
  • Attached examples

Test Configuration:

  • RFEM version: 6.06.0007
  • Python version: 3.11

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@OndraMichal OndraMichal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test raises assert but not sure if it is caused by the changes.
image

RFEM/SpecialObjects/surfaceResultsAdjustment.py Outdated Show resolved Hide resolved
RFEM/SpecialObjects/surfaceResultsAdjustment.py Outdated Show resolved Hide resolved
RFEM/SpecialObjects/surfaceResultsAdjustment.py Outdated Show resolved Hide resolved
Copy link
Contributor

@OndraMichal OndraMichal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work.

@heetrojivadiya heetrojivadiya merged commit 4960d1a into main Jun 17, 2024
1 of 2 checks passed
@heetrojivadiya heetrojivadiya deleted the heet-surfaceResultsAdjustment branch June 17, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants