This repository has been archived by the owner on Jul 1, 2020. It is now read-only.
Scan Inverted QR Code #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @dm77 |
|
@manijshrestha Sure. Thank you for the PR. I unfortunately can't get it to scan inverted qr codes on either Nexus 5 or Google Pixel. Were you able to scan any inverted qr codes with your fix? |
|
Yes I was, I tested this on Pixel, Nexus 6p, 5X Sammy S6, S7 and couple more. |
|
Ok thank you so much for confirming. Seems like I need to refresh Android studio, trying again.. |
|
Oops forgot this in build.gradle compile project(":zxing"). Works great now. Thank you |
|
Ok this is now merged in v1.9.1. Thank you again. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There has been a lot of requests to be able to scan inverted QR code.
zxing/zxing#194
This change allows to scan inverted QR Code