-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add data sources to extract node and device information #1042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustydb
reviewed
Oct 24, 2023
Co-authored-by: Russell Bunch <doomslayer@hpe.com>
Co-authored-by: Mike Beaumont <mjboamail@gmail.com>
michaelbeaumont
approved these changes
Dec 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
michaelbeaumont
changed the title
Added support for data sources to extract node and device information
feat: add data sources to extract node and device information
Dec 28, 2023
This was referenced Feb 23, 2024
Still puzzled how the test ever passed:
|
memetb
pushed a commit
to memetb/terraform-provider-libvirt
that referenced
this pull request
Sep 23, 2024
this is related to the conversation in issue dmacvicar#1074. The original implementation of nodeinfo (as released in PR dmacvicar#1042) has a bug - which may very well be easily fixed - however the current PR and branch specifically addressed that issue by calling virConnectGetCapabilities instead of virNodeGetInfo. Instead of doing this, a new feature "host_capabilities" is added, and the nodeinfo code is left unchanged (it may be addressed in a separate PR)
dmacvicar
pushed a commit
to jimnydev/terraform-provider-libvirt
that referenced
this pull request
Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
this PR adds support for new data sources:
libvirt_node_info
- to retrieve node information and make it available to Terraform. (virsh nodeinfo
)libvirt_node_devices
- retrieves the list of devices available in the node, can be filtered by capability. (virsh nodedev-list
)libvirt_node_device_info
- retrieves information about a single device. (virsh nodedev-dumpxml
)Apart from the changes to
docs
andprovider.go
to plugin in the documentation and the new resources, changes are in new files.