Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(prebid):additional parameter[PREB-1] #4

Merged
merged 2 commits into from
Apr 22, 2021
Merged

feat(prebid):additional parameter[PREB-1] #4

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4791129
feat(prebid):additional parameter[PREB-1]
Apr 22, 2021
9582756
feat(prebid):update decode function and cacheobi[PREB-1]
Apr 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions modules/dmdIdSystem.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,11 @@ export const dmdIdSubmodule = {
* performs action to obtain id and return a value in the callback's response argument
* @function getId
* @param {SubmoduleConfig} [config]
* @param {ConsentData}
* @param {Object} cacheIdObj - existing id, if any consentData]
* @returns {IdResponse|undefined}
*/
getId(config) {
getId(config, consentData, cacheIdObj) {
try {
const configParams = (config && config.params) || {};
if (
Expand All @@ -43,11 +45,11 @@ export const dmdIdSubmodule = {
typeof configParams.api_key !== 'string'
) {
utils.logError('dmd submodule requires an api_key.');
return;
}
} catch (e) {
utils.logError(`dmdIdSystem encountered an error`, e);
}
return cacheIdObj;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we return this object even when api_key is invalid?

},
};

Expand Down