Reset notifier before first fork #8
Conversation
The previous version of rollbar_spec.rb would pass even if `lib/resque/rollbar.rb`'s `before_first_fork` block was empty since it used the default Rollbar configuration which is synchronous.
Fixes cases where a `Notifier` may have been created prior to the Rollbar initializer calling `Rollbar.configure`. Previously Resque would continue to use this prematurely created `Notifier` and never use the `Configuration` defined by the initializer. See rollbar/rollbar-gem#183
jonah-williams
force-pushed
the
reset_notifier_before_first_fork
branch
3 times, most recently
from
8fae944 to
d5f3091
Compare
|
Is maintaining Rollbar 0.8.x compatibility still important for this gem? If so how would you like to handle spec cases and Rollbar method calls which are only available in the Rollbar 1.x release? |
|
The call to I think the spec here is still a false positive, at least when running against Rollbar 1.x so it might be worth addressing in any case. |
I think we should release a new version for >= 1.2.0 only. |
|
@dimko sure thing, how does this look now? |
…_fork Reset notifier before first fork
|
Just merged, thanks for the contribution and sorry for the delay! |
Fixes cases where a
Notifiermay have been created prior to the Rollbar initializer callingRollbar.configure. Previously Resque would continue to use this prematurely createdNotifierand never use theConfigurationdefined by the initializer. See rollbar/rollbar-gem#183