Improvments for next release #208
Conversation
Change info tab into overview tab Change settings tab into keyboard tab
Main point of these changes, besides the need to port to Qt6, is to give access to the most used options in a single page that appears first when the interface is opened. The changes: Moved the shift mode selection to the first page Removed the Mode tab and page entirely Toggles have been also moved to the first page Renamed the tab (page) the Overview tab Renamed the settings tab to Keyboard tab (since the only Options left are keyboard related) Moved EC version and build date from the overview page to the about page More changes: The interface won't be resizable anymore, that's for avoiding it getting tiled by tiling window managers or scripts that emulate tiling on normal (stacking) desktop environments. this was done to avoid wasted space in case the interface was the only window visible on the screen. Side changes: About page: mention msi-ec as the driver and add a github link for it. Debug page: add warning against randomly writing to EC memory. The new interface was tested with multiple Qt themes and seems to look and function fine.
Require the new lupdate-qt6. Hard coded the path to /lib/qt6/bin because it seems find_executable is failing to find the necessary binaries even though they exist, however, this change needs more testing (confirmed to work on Arch Linux).
Added lines to indicate that the script has started/finished
The straw that made the camel trip and fall
New images reflects how different themes might look on the app Supported devices link now redirects to msi-ec, where the should be consulted.
|
Hello By default, the "Overview" tab should open (after launching the application, the "Fan control" tab is open by default). Is it really necessary to limit the window size? In some languages the text may not fit. |
|
Last 2 fixes should've been done in one commit, i got confused as to how and why they got changed in the first place |
not at all, its just a quality of life improvement, because if it was the only window open on a tiling window manager, it will get maximized, and it becomes an empty screen with way too much wasted space, making it harder to find what you're looking for. tiling scripts will tile the window even if it's only resizable by 1 pixel, that's why i chose to fix the window size. if you have any better ideas i'm open to suggestions
we might need to update translations to use shorter strings for example |
|
also can i ask what distribution are you using to test this pull request? is there any problems with cmake or missing binaries errors? |
I'm using openSUSE Tumbleweed. There was a problem with lupdate and lrelease. In my distro they are called lupdate6 and lrelease6.
It would be good to check how the application window is displayed when scaling is enabled. |
PATHS will have to stay for now until i figure out why qt6-tools on arch doesn't have ```lupdate``` and ```lrelease``` in /usr/bin
Scaling for regular Qt widgets is not a good idea since its handled by the system, i don't know if its even an option since talking about scaling means Qt Quick which is another story for another time. The current interface seems to react better when maximized, there seem to be an acceptable spacing between text and elements so there shouldn't be any issues and the possibility to unlock window resizing is not out of the question, but depends whether or not you find it good looking at this state.
|
|
Just to clarify things: i don't want the next release to be held by this pull request, i prefer that we have a release that uses msi-ec without this pull request being merged rather than the current version that doesn't use the driver at all. |
fixes the 4 warnings in mainwindow.cpp: alias template deduction only available with ‘-std=c++20’ or ‘-std=gnu++20’ line 466 to 469
|
thanks for the merge, all is left is to make a new release, what version number did you choose? |
It will be 0.5.0 |
|
Dude, I refresh the page every day to see if a new version has been released. You have perhaps made the single most comprehensive management application for MSI devices running Linux. You have done a great job. I hope you release a new version soon. |
I'll try to release it this weekend. |
|
Maybe there is still a chance for release to happen today 🥹 |
|
@CemCanplt you can build it and install it yourself you know? |
|
@mutchiko The truth is I don't know how, I've seen the update you've made to the script but I don't know how to put it together as a program. |
|
@CemCanplt clone the repo as a zip (not from releases) and: 1-open the terminal in the extracted directory |
|
I'll try, thank you @mutchiko |
|
Hello again @mutchiko I've run the build.sh, it gave me 2 error-ish respond
Then I have run the ./create_installer.sh file, sadly it didn't create a zip file, the output was:
Since there is no zip file, I can't continue, that's my life I presume, it always happens to me, nothing works flawlessly if I am on Linux :( That's why I usualy beg for an official release. I have used "sudo" before running the scripts. What should I do next? |
|
I assume I can download cmake from software center |
|
@mutchiko I have installed a thing named cmake from software center, then ran the build.sh again, this time, it gives me this error, I suppose this is the Qt6 thingy you've been talking about: -- The CXX compiler identification is GNU 13.3.0 Qt6Config.cmake Add the installation prefix of "QT" to CMAKE_PREFIX_PATH or set "QT_DIR" to -- Configuring incomplete, errors occurred! |
|
@CemCanplt i've made a release just for you on my fork : https://github.com/mutchiko/MControlCenter/releases/tag/0.4.9-beta before you start, install now download the tar.gz from the link above the terminal will show you some errors after you execute install.sh, please report them here |
|
correction: Qt6-wayland is optional, however, other Qt6 packages are important |
|
@mutchiko Thanks for the help, I cannot believe you've created a fork just for me 🥹, so I have good news and bad news, the good news is installation seems fine: Installation start The bas news is Control Center doesn't start when I double click to it. I've tried to run it through to terminal in order to see if I can get any error message. I have one. mcontrolcenter: error while loading shared libraries: libQt6Widgets.so.6: cannot open shared object file: No such file or directory Sadly there is no Qt6 packages on Software Center besides Qt6-Wayland, I have tried to install it via "sudo apt install libQt6Widgets" and "sudo apt install libQt6Widgets.so.6" but it says there is no such package. |
|
Update: I did "sudo apt install qt6-base-dev" and now my problem went from "mcontrolcenter: error while loading shared libraries: libQt6Widgets.so.6: cannot open shared object file: No such file or directory" to "mcontrolcenter: /lib/x86_64-linux-gnu/libQt6Core.so.6: version `Qt_6.8' not found (required by mcontrolcenter)" |
|
@CemCanplt okay thats better, my system has Qt6.8 LTS but other distros just don't ship something up to date, i will try to find a way to make this version requirement go away |
|
@CemCanplt i think you should be able to try this again #208 (comment) |
|
@mutchiko I think it's working? In case anyone reads this, firstly I did "sudo apt install qt6-tools-dev" then "sudo apt install qt6-base-dev". Then what says in the comment "#208 (comment)" Then it seems to be working, let me check, at least it opens. |
|
@CemCanplt screen shots please |
|
There it is, Dark Theme looks so cool |
|
Keyboard Light doesn't seem to be working (it didn't work on last release too), I just wanted to know if it's fixable. |
|
@CemCanplt Qt tries to make itself as close as possible to your system, there are some graphical problems in the screen shots but its not big. what is your laptop model? |
|
|
@CemCanplt in step 4 #208 (comment) there was a new zip file that was generated, could you please send it here? |
|
I assume this one? |
|
@CemCanplt please check the about page in the app "hakkinda" and go to the msi-ec github, then find the support guide in readme and follow it. you can contact me here or on msi-ec issues if you have opened a support issue. your laptop is only partially supported, i can't guarantee that new functions will be unlocked, but its important to add support for your device in the driver and install the latest version. |
|
@mutchiko I guess I understand what you want me to do but I don't understand why this is any useful to anyone. |
|
@CemCanplt msi-ec driver cant support every msi laptop, because each model is different, there is no way to support models without extracting specific information about the features on each model, the only way to do that is for someone with that laptop to follow the guide and give us the addresses for the features, and we handle the rest. MConctrolCenter relies on that driver to make changes on your system, what you did now is just build the graphical part of the app, the driver is different. |
|
So you are saying that If giveaway my laptops some sort of driver information to you by following the steps, in time you can build a way to support my laptop in the future, this would also help other who has the same laptop too, right? @mutchiko That way I would be helping the Msi Linux Driver Compability Thingy I assume, this is cool. |
|
It's like how github works I guess |
|
@CemCanplt this is exactly how it goes, and all models on the supported devices list are people who discovered how to add support without the guide, i wrote that guide myself after i added support for my laptop and helped other people who have the same model gain performance that was lost before you can change the performance mode |
|
@mutchiko |
|
@CemCanplt what driver are you trying to install? official msi driver? |
|
@mutchiko No Msi Drivers are running with no issue. RwPortableX64V1.7 - The app that from "device_support_guide.md", when I've tried run it Windows warned me that this thing might be dangerous and if I still want to run it I must disable the "memory integrity" from Windows Defender. |
|
@CemCanplt it seems like you're on win11, unfortunately the app hasn't been updated for win11, because new windows versions add new security measures that you need to follow. the app is 100% safe, win10 doesn't show this error (not for me at least), and you can't harm your laptop if you follow the guide. |
|
|
|
@CemCanplt we are getting out of context here, please open a new issue on msi-ec (title: add support for + put the model) so we can get more people to help you |
|
Okay @mutchiko |
|
@mutchiko Sorry, I was hasty. I opened the topic as a bug. Hope you don't mind. I apologize. |
Build against Qt6 with graphical modifications presented on the readme page.
The commits are self explanatory, there might be some translation issues, but i couldn't test.
Version bump is also waiting since this is not for me to decide.