[Feature] Reimplement Immutable graph index in DGL #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zheng-da
force-pushed
the
immutable_graph
branch
from
e161e45 to
e983219
Compare
zheng-da
changed the title
jermainewang
reviewed
Jan 7, 2019
szha
reviewed
Jan 8, 2019
BarclayII
reviewed
Jan 9, 2019
BarclayII
reviewed
Jan 9, 2019
zheng-da
force-pushed
the
immutable_graph
branch
from
52bb617 to
5a7d688
Compare
|
finally addressed all comments. |
BarclayII
reviewed
Jan 15, 2019
BarclayII
approved these changes
Jan 15, 2019
jermainewang
requested changes
Jan 16, 2019
There was a problem hiding this comment.
Final batch of comments. I didn't go through the sampler codes in immutable_graph.cc. Too much for this PR already. I suggest, later when @BarclayII works on the random walk stuff, try to go through that again and see what happens and could be merged. What do you think @BarclayII ?
|
Agreed. @GaiYu0 your layer sampling depends on this PR as well, right? |
|
I am fine as long as there is no change in major interface. |
zheng-da
force-pushed
the
immutable_graph
branch
from
293e1a2 to
e43b917
Compare
jermainewang
approved these changes
Jan 16, 2019
|
Approved. Thanks Da! |
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is to reimplement immutable graph index in DGL. This is a framework-agnostic implementation.
Checklist
Please feel free to remove inapplicable items for your PR.
or have been fixed to be compatible with this change
Changes