[rabit harden] address subprocess exit deadlock #524
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chenqin Given that Python 2.x would be EOL end of this year, wouldn't using Python 3 solve the issue? |
|
yes, and it would be nice if you can help to test xgboost's tracker in python3 |
|
python3 seems work on my ubuntu and osx, just confirm, so are we agree to move foward and end support of python2 in next release? |
|
@chenqin @CodingCat I opened a new thread to get votes from the community: dmlc/xgboost#4379. Related: apache/tvm#2994 |
|
too many PRs opened and it becomes hard to track which one we should focus on close this one as we are moving to py3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue20318 Caused rabit test hang and timeout from time to time. As python community has no plan to fix in 2.7. We should use process to replace thread to run each rabit worker.