Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

[FEATURE]Horovod support for training transformer + add mirror data for wmt (PART 1) #1284

Merged
merged 22 commits into from
Aug 7, 2020

Conversation

hutao965
Copy link
Contributor

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • horovod support for training transformer and add split option for BoundedBugdetSampler
  • add mirror wmt data source

@hutao965 hutao965 requested a review from sxjscience July 31, 2020 01:30
@codecov
Copy link

codecov bot commented Jul 31, 2020

Codecov Report

Merging #1284 into numpy will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            numpy    #1284      +/-   ##
==========================================
+ Coverage   83.60%   83.68%   +0.08%     
==========================================
  Files          42       42              
  Lines        6375     6382       +7     
==========================================
+ Hits         5330     5341      +11     
+ Misses       1045     1041       -4     
Impacted Files Coverage Δ
src/gluonnlp/data/sampler.py 96.22% <100.00%> (+0.10%) ⬆️
src/gluonnlp/layers.py 86.78% <0.00%> (ø)
src/gluonnlp/embedding/embed_loader.py 81.52% <0.00%> (ø)
src/gluonnlp/utils/misc.py 44.69% <0.00%> (+1.28%) ⬆️

@sxjscience
Copy link
Member

@hymzoque The horovod PR has been merged. Would you merge master?


| Subword Model | #Params | Seed = 123 | Seed = 1234 | Seed = 12345 | Mean±std |
|---------------|------------|-------------|-------------|--------------|-------------|
| yttm | | 26.63 | 26.73 | | - |
| yttm | | 27.99 | - | - | - |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@szhengac Does the Transformer-Big results look reasonable to you?

@sxjscience
Copy link
Member

LGTM in general, you may add some transformer_base numbers.

@hutao965 hutao965 changed the title [FEATURE]Horovod support for training transformer + add mirror data for wmt [FEATURE]Horovod support for training transformer + add mirror data for wmt (PART 1) Aug 7, 2020
Copy link
Member

@sxjscience sxjscience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve and merge for now. Still need to wait for PART2, which adds horovod command and results of TransformerBase.

@sxjscience sxjscience merged commit c33e62e into dmlc:numpy Aug 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants