This repository has been archived by the owner on Jan 15, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 538
[FEATURE]Horovod support for training transformer + add mirror data for wmt (PART 1) #1284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## numpy #1284 +/- ##
==========================================
+ Coverage 83.60% 83.68% +0.08%
==========================================
Files 42 42
Lines 6375 6382 +7
==========================================
+ Hits 5330 5341 +11
+ Misses 1045 1041 -4
|
zheyuye
reviewed
Jul 31, 2020
@hymzoque The horovod PR has been merged. Would you merge master? |
sxjscience
reviewed
Aug 2, 2020
sxjscience
reviewed
Aug 5, 2020
sxjscience
reviewed
Aug 5, 2020
sxjscience
reviewed
Aug 5, 2020
|
||
| Subword Model | #Params | Seed = 123 | Seed = 1234 | Seed = 12345 | Mean±std | | ||
|---------------|------------|-------------|-------------|--------------|-------------| | ||
| yttm | | 26.63 | 26.73 | | - | | ||
| yttm | | 27.99 | - | - | - | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@szhengac Does the Transformer-Big results look reasonable to you?
LGTM in general, you may add some transformer_base numbers. |
hutao965
changed the title
[FEATURE]Horovod support for training transformer + add mirror data for wmt
[FEATURE]Horovod support for training transformer + add mirror data for wmt (PART 1)
Aug 7, 2020
sxjscience
approved these changes
Aug 7, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll approve and merge for now. Still need to wait for PART2, which adds horovod command and results of TransformerBase.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Essentials
Changes