This repository has been archived by the owner on Jan 15, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[TVM] Add TVM Support #1390
[TVM] Add TVM Support #1390
Changes from 48 commits
c35bf54
0f16b3c
c6cfa1c
958971b
3b1e095
1e3b6c3
0928ee3
74b0cee
d76ddaa
cafbc45
3ebaf9f
f4d4bd4
b2ee011
c10957b
4f7285e
b418a83
096b6b8
a64d234
e5305e8
23fdc42
28c7032
44833e8
b495794
70e6090
98fd846
43b26c6
03b7ca7
9c6ee2d
288b208
2f51234
c44f6e7
202d87c
eb7a362
8a0d561
4109cd9
ee1fabf
1a45b59
76d4851
683a032
ade7089
d0cfc64
668fee3
8ace01f
0da3696
4f6d7f2
0cdb33d
0ddb1a8
a870066
30b9a7b
aa4674b
899f1b1
6c61030
60452b2
bb55741
f43347a
4312864
8908137
d294a6f
38502dd
cc0122c
2573b20
71f6b8e
73742fb
dd1e499
0c01e46
4947342
1bedbfa
b8d2518
30b561c
baa83d0
a99cda6
1e1b05d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unused?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean llvm or
libedit-dev libxml2-dev
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For LLVM, it's used in TVM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May be it's too slow to ask Github actions to test TVM and I'm considering to remove the check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've revised the test case to only test one model when it's on CPU.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've marked it as resolved. Feel free to update your concern.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://tvm.apache.org/docs/install/from_source.html#developers-get-source-from-github
According to the instructions, you don't need to add the upstream llvm repo. You can just use the llvm version available on Ubuntu itself. It may faster and less flaky (upstream website may be more likely to be unavailable at times).