Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Run tests on Windows #101

Merged
merged 19 commits into from
Oct 8, 2019
Merged

[CI] Run tests on Windows #101

merged 19 commits into from
Oct 8, 2019

Conversation

hcho3
Copy link
Collaborator

@hcho3 hcho3 commented Jun 19, 2019

I ended up finding some issue when the unit tests were run on the Windows target.

@hcho3 hcho3 changed the title Run tests on Windows [CI] Run tests on Windows Jun 19, 2019
@codecov-io
Copy link

codecov-io commented Jun 19, 2019

Codecov Report

Merging #101 into master will decrease coverage by 0.23%.
The diff coverage is 71.01%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     dmlc/treelite#101      +/-   ##
============================================
- Coverage     86.15%   85.91%   -0.24%     
  Complexity       49       49              
============================================
  Files            81       81              
  Lines          5741     5772      +31     
  Branches         37       37              
============================================
+ Hits           4946     4959      +13     
- Misses          768      786      +18     
  Partials         27       27
Impacted Files Coverage Δ Complexity Δ
python/treelite/frontend.py 72.56% <100%> (+0.09%) 0 <0> (ø) ⬇️
tests/python/test_basic.py 100% <100%> (ø) 0 <0> (ø) ⬇️
tests/python/test_lightgbm_integration.py 97.43% <100%> (ø) 0 <0> (ø) ⬇️
tests/python/test_model_builder.py 100% <100%> (ø) 0 <0> (ø) ⬇️
python/treelite/common/util.py 97.05% <100%> (+15.24%) 0 <0> (ø) ⬇️
python/treelite/contrib/__init__.py 65.97% <50%> (-2.26%) 0 <0> (ø)
src/compiler/ast_native.cc 90.56% <68.18%> (-5.95%) 0 <0> (ø)
runtime/native/src/thread_pool/spsc_queue.h 94.44% <0%> (+5.55%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77b8442...a59d18e. Read the comment docs.

@hcho3 hcho3 closed this Sep 10, 2019
@hcho3 hcho3 reopened this Sep 10, 2019
@hcho3 hcho3 mentioned this pull request Sep 10, 2019
3 tasks
@hcho3 hcho3 force-pushed the add_win_tests branch 2 times, most recently from 3b1370e to 692e934 Compare October 6, 2019 07:27
@hcho3
Copy link
Collaborator Author

hcho3 commented Oct 6, 2019

There is a bug in subprocess.Popen() on Windows: https://bugs.python.org/issue37380. The bug is causing crash in export_lib(). This bug was fixed in latest versions of 3.7 and 3.8 (dev) (python/cpython#14360). I will try to update Python in the test runner and see if crash is fixed.

@hcho3
Copy link
Collaborator Author

hcho3 commented Oct 6, 2019

Using latest Python doesn't make any difference. I'd have to conclude that Azure Pipelines doesn't let a process to write to a temporary directory underC:\\Users\\VssAdministrator\\AppData\\Local\\Temp.

@hcho3
Copy link
Collaborator Author

hcho3 commented Oct 8, 2019

Note to myself: the LETOR model takes inordinately long time to compile on Windows (with MSVC), taking more than an hour (the job gets killed by Azure Pipelines). The same model takes < 5 minutes on Linux however. I suspect it has to do with IO performance difference between Linux and Windows.

@hcho3 hcho3 merged commit 4396eab into dmlc:master Oct 8, 2019
@hcho3 hcho3 deleted the add_win_tests branch October 8, 2019 08:02
fengjixuchui added a commit to fengjixuchui/treelite that referenced this pull request Oct 8, 2019
[CI] Run tests on Windows (dmlc#101)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants