Cleanup.

dmlc · Oct 10, 2024 · 7772803 · 7772803
1 parent 19f4191
commit 7772803
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 12 deletions.
diff --git a/src/common/timer.cc b/src/common/timer.cc
@@ -7,7 +7,6 @@
 
 #include "../collective/communicator-inl.h"
 #include "cuda_rt_utils.h"
-#include <unistd.h>  // for getpid
 
 #if defined(XGBOOST_USE_NVTX)
 #include <nvtx3/nvtx3.hpp>

diff --git a/src/tree/updater_gpu_hist.cu b/src/tree/updater_gpu_hist.cu
@@ -738,11 +738,9 @@ struct GPUHistMakerDevice {
       std::copy_if(expand_set.begin(), expand_set.end(), std::back_inserter(valid_candidates),
                    [&](auto const& e) { return driver.IsChildValid(e); });
 
-      monitor.Start("new_candidates");
       // Allocaate children nodes.
       auto new_candidates =
           pinned.GetSpan<GPUExpandEntry>(valid_candidates.size() * 2, GPUExpandEntry());
-      monitor.Stop("new_candidates");
 
       this->PartitionAndBuildHist(p_fmat, expand_set, valid_candidates, p_tree);
 

diff --git a/tests/ci_build/build_via_cmake.sh b/tests/ci_build/build_via_cmake.sh
@@ -21,17 +21,12 @@ else
   cmake_prefix_flag=''
 fi
 
-# rm -rf build
-# mkdir build
-
-if [ ! -d build ]; then
-    mkdir build
-fi
-
+rm -rf build
+mkdir build
 cd build
 # Disable CMAKE_COMPILE_WARNING_AS_ERROR option temporarily until
 # https://github.com/dmlc/xgboost/issues/10400 is fixed
-echo "cmake: ${cmake_args}"
-cmake .. ${cmake_args} -DCMAKE_VERBOSE_MAKEFILE=ON -DENABLE_ALL_WARNINGS=ON -DCMAKE_COMPILE_WARNING_AS_ERROR=OFF -GNinja ${cmake_prefix_flag} -DHIDE_CXX_SYMBOLS=ON -DCMAKE_BUILD_TYPE=RelWithDebInfo
+cmake .. ${cmake_args} -DGOOGLE_TEST=ON -DUSE_DMLC_GTEST=ON -DCMAKE_VERBOSE_MAKEFILE=ON -DENABLE_ALL_WARNINGS=ON -DCMAKE_COMPILE_WARNING_AS_ERROR=OFF -GNinja ${cmake_prefix_flag} -DHIDE_CXX_SYMBOLS=ON -DBUILD_DEPRECATED_CLI=ON
+ninja clean
 time ninja -v
 cd ..