-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Fix JVM tests on Windows #10404
Conversation
Update: The Steps taken:
$env:MAVEN_SKIP_NATIVE_BUILD=1
mvn test -B -pl :xgboost4j_2.12 |
I probably spent too much time on this. I will try to move the JVM tests to BuildKite and see if it works. |
Given that 2.1.0 release is just around the corner, I am choosing the least disruptive option (Option 2). |
Even when I tried running Java and Python separately, I still get the same error ( |
As fate has it, the DLL error had nothing to do with duplication of core libraries. The DLL error was actually caused by improper mixing of two modes of linking for the C runtime. Background: On Windows, you can choose to link with the C runtime dynamically ( Fix. Use a more robust method to enforce the |
@trivialfis Looks like the CI is unblocked now. Can you review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huge thanks for the fix!
https://github.com/dmlc/xgboost/actions/runs/9470870529/job/26092755865
Closes #10344