Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dask] Disable broadcast in the scatter call. #10632

Merged
merged 1 commit into from
Jul 24, 2024
Merged

[dask] Disable broadcast in the scatter call. #10632

merged 1 commit into from
Jul 24, 2024

Conversation

trivialfis
Copy link
Member

@trivialfis trivialfis commented Jul 24, 2024 •
edited
Loading

As noted in the scatter document, when AMM is enabled (default), the broadcast flag is invalid).

Huge thanks to @rjzamora @dantegd for debugging this.

@trivialfis trivialfis requested a review from hcho3 July 24, 2024 16:58
@trivialfis trivialfis mentioned this pull request Jul 24, 2024
Closed
15 tasks
rjzamora
rjzamora approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@rjzamora rjzamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me, thanks!

It seems possible that broadcast=True will scale a bit better when the number of workers in large. However, I think it makes sense to keep the fix simple (as this PR does) until you find clear motivation to optimize further.

@trivialfis trivialfis merged commit fcae630 into dmlc:master Jul 24, 2024
30 checks passed
@trivialfis trivialfis deleted the dask-predict-scatter branch July 24, 2024 20:16
trivialfis added a commit to trivialfis/xgboost that referenced this pull request Jul 24, 2024
@trivialfis
[backport][dask] Disable broadcast in the scatter call. (dmlc#10632)
96a6349
trivialfis added a commit that referenced this pull request Jul 25, 2024
@trivialfis
[backport][dask] Disable broadcast in the scatter call. (#10632) (#…
3fd8451 
…10634)
@hcho3 hcho3 mentioned this pull request Jul 30, 2024
Merged
@trivialfis trivialfis mentioned this pull request Aug 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjzamora rjzamora rjzamora approved these changes

@hcho3 hcho3 hcho3 approved these changes

Assignees
No one assigned
Labels
Blocking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trivialfis @hcho3 @rjzamora