Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POSIX compliant poll.h and mmap over sys/poll.h and mmap64 #10767

Merged
merged 1 commit into from
Sep 1, 2024

Conversation

SamuelMarks
Copy link
Contributor

Closes #10737

Basic build testing confirms this works with both musl and glibc:

FROM alpine
RUN apk add --no-cache cmake gcc g++ make musl-dev
WORKDIR /src/xgboost
COPY . .
RUN cmake -S . -B build && \
    cmake --build build
FROM debian:bookworm-slim
RUN apt-get update -qq && \
    apt-get install -y cmake gcc g++ make libstdc++6 && \
    rm -rf /var/lib/apt/lists/*
WORKDIR /src/xgboost
COPY . .
RUN cmake -S . -B build && \
    cmake --build build

… [include/xgboost/collective/poll_utils.h] Use `poll.h` over `sys/poll.h` to resolve MUSL warning
@SamuelMarks SamuelMarks mentioned this pull request Aug 30, 2024
Copy link
Member

@trivialfis trivialfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@trivialfis trivialfis merged commit 4503555 into dmlc:master Sep 1, 2024
30 checks passed
@snoopcheri
Copy link
Contributor

Great to see this fixed, as we stumbled over this problem ourselves as well!
I assume this will be part of the 2.2.x release?

@trivialfis
Copy link
Member

We will probably make a patch release.

@trivialfis trivialfis mentioned this pull request Oct 11, 2024
10 tasks
trivialfis pushed a commit to trivialfis/xgboost that referenced this pull request Oct 14, 2024
trivialfis added a commit that referenced this pull request Oct 16, 2024
* [bp] POSIX compliant `poll.h` and `mmap` (#10767)

* Freeze hypothesis.

---------

Co-authored-by: Samuel Marks <807580+SamuelMarks@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants