[WIP] Reimplement lambdamart ndcg. #6465
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Question to myself: Is there a way to use cub sort pair with discard iterator to avoid allocating an array? |
hcho3
requested changes
Dec 15, 2020
Merged
* Simplify the implementation for both CPU and GPU. Fix JSON IO. Check labels. Put idx into cache. Optimize. File tag. Weights. Trivial tests. Compatibility. Lint. Fix swap. Device weight. tidy. Easier to read R failure. enum. Fix global configuration. Tidy. msvc omp. dask. Remove ndcg specific parameter. Drop label type for smaller PR. Fix rebase. Fixes. Don't mess with includes. Fixes. Format. Use omp util. Restore some old code.
|
Closing to avoid spamming the list. Will reopen once ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #6450
ndcg_truncation.ndcg@truncation.TODOS: