Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop binary format for memory snapshot. #6513

Merged
merged 1 commit into from
Dec 16, 2020

Conversation

trivialfis
Copy link
Member

  • Remove saving binary snapshot. Loading is preserved for now.

@trivialfis
Copy link
Member Author

Note: JSON snapshot was flipped on as default in 1.3.

@trivialfis trivialfis mentioned this pull request Dec 16, 2020
23 tasks
@codecov-io
Copy link

codecov-io commented Dec 16, 2020

Codecov Report

Merging #6513 (fcd8232) into master (0e97d97) will increase coverage by 80.38%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #6513       +/-   ##
===========================================
+ Coverage        0   80.38%   +80.38%     
===========================================
  Files           0       13       +13     
  Lines           0     3559     +3559     
===========================================
+ Hits            0     2861     +2861     
- Misses          0      698      +698     
Impacted Files Coverage Δ
python-package/xgboost/data.py 56.96% <0.00%> (ø)
python-package/xgboost/sklearn.py 89.61% <0.00%> (ø)
python-package/xgboost/rabit.py 78.57% <0.00%> (ø)
python-package/xgboost/dask.py 81.78% <0.00%> (ø)
python-package/xgboost/core.py 81.05% <0.00%> (ø)
python-package/xgboost/compat.py 73.33% <0.00%> (ø)
python-package/xgboost/__init__.py 89.47% <0.00%> (ø)
python-package/xgboost/plotting.py 73.52% <0.00%> (ø)
python-package/xgboost/config.py 100.00% <0.00%> (ø)
python-package/xgboost/libpath.py 55.55% <0.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e97d97...fbe1305. Read the comment docs.

@trivialfis trivialfis merged commit c587627 into dmlc:master Dec 16, 2020
@trivialfis trivialfis deleted the drop-binary-snapshot branch December 16, 2020 16:15
pseudotensor added a commit to h2oai/xgboost that referenced this pull request Dec 18, 2020
pseudotensor added a commit to h2oai/xgboost that referenced this pull request Dec 18, 2020
This reverts commit c587627.

Temporary revert to avoid risk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants