-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BREAKING] Cleanup gpu_id
configuration.
#6971
Conversation
gpu_hist
when gpu_id
is set.gpu_id
configuration.
@RAMitchell @hcho3 I will probably close this PR and open a different one to simply fix the bug. Getting it to work without some user-visible breaking changes seems impossible. For example: Setting "gpu_hist" leads to
then if a user wants to run prediction on the CPU, he will set
then xgboost will throw an error as |
I'm picking up this PR again. Will proceed with breaking changes. |
Recently found a bug that was introduced in updating the prediction cache for
gpu_hist
. When a custom objective is used, the gradient is on CPU. This PR fixes it by prioritizing thegpu_id
parameter.Other than the bug fix, this PR also tries to cleanup and clarify the configuration of this parameter. Please see the note in
gbtree.cc
for details.Here breaking means, one can no longer run into edge cases like having
gpu_id = 0
while running CPUexact
. Overall it should not change normal usage.Todos: