Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Muting the remaining messages when show_progress=False #827

Merged
merged 1 commit into from
Feb 19, 2016
Merged

Muting the remaining messages when show_progress=False #827

merged 1 commit into from
Feb 19, 2016

Conversation

ivallesp
Copy link
Contributor

I was using the library and I found that when doing a cross validation, even when I chose the parameter show_progress to False, it showed some messages:

"Will train until cv error hasn't decreased in X rounds", in case of having early_stopping

"Stopping. Best iteration:\n[X] cv-mean:[...]\n"

I wrote some conditions for muting it when show_progress=Fase because if you run a bunch of models with a grid of parameters, the high number of messages can bother :D.

@tqchen
Copy link
Member

tqchen commented Feb 16, 2016

Sorry for the delayed reply. Let us reuse the verbose_eval parameter

@ivallesp
Copy link
Contributor Author

Ok I see, I changed it! is it ok now?

The travis tests are failing because I changed the name of the parameters, but the code should work correctly

@tqchen
Copy link
Member

tqchen commented Feb 19, 2016

please do a rebase to merge your commits, and it will be merged.http://xgboost.readthedocs.org/en/latest/dev-guide/contribute.html#how-to-combine-multiple-commits-into-one

@ivallesp
Copy link
Contributor Author

done :D!

tqchen added a commit that referenced this pull request Feb 19, 2016
Muting the remaining messages when show_progress=False
@tqchen tqchen merged commit 532615a into dmlc:master Feb 19, 2016
@tqchen
Copy link
Member

tqchen commented Feb 21, 2016

@ivallesp It seems that I merged the change too hastely and now the travis test break due to the change introduced by this PR, https://travis-ci.org/dmlc/xgboost/builds/110415766

Please make a PR to fix this issue, so the other changes can be savely merged in.

@tqchen
Copy link
Member

tqchen commented Feb 21, 2016

@ivallesp
Copy link
Contributor Author

@tqchen I just did it! Sorry but I made something wrong during the squash and the changes in the training file were not applied. I think it is solved now. Let's wait until tests done. Thank you for reporting it.

@ivallesp
Copy link
Contributor Author

@tqchen yep! Now the tests passed and it is working correctly. Sorry for the inconvenience.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants