[pyspark] fix a minor typing bug #9079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`from xgboost.spark import SparkXGBClassifier` will throw exception
when running on older pyspark (3.2.1) with the error msg
``` python
---> 16 arbitrary_params_dict: Param[Dict] = Param(
17 Params._dummy(),
18 "arbitrary_params_dict",
19 "arbitrary_params_dict This parameter holds all of the additional parameters which are "
20 "not exposed as the the XGBoost Spark estimator params but can be recognized by "
21 "underlying XGBoost library. It is stored as a dictionary.",
22 )
TypeError: 'type' object is not subscriptable
```
Change the typing to "Param[Dict]"
trivialfis
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from xgboost.spark import SparkXGBClassifierwill throw exception when running on older pyspark (3.2.1) with the error msgChange the typing to "Param[Dict]"