-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move python tool configurations to pyproject.toml, and add the python 3.11 classifier. #9112
Move python tool configurations to pyproject.toml, and add the python 3.11 classifier. #9112
Conversation
… 3.11 classifier.
Hey @trivialfis @hcho3, |
For |
@trivialfis please let me try to do it myself first, will do so very soon. |
Thank you for the nice work! Let me know if there's anything I can help. |
@trivialfis am I free to use the builtin library |
yup, whatever that comes with python. |
Thanks for working on updating the linting script. Let me know if there's anything I can help. |
@hcho3 @trivialfis I think I'm done here, locally everything works. ...
mypy_results = [
run_mypy(path)
for path in [
# core
"python-package/",
# demo
"demo/json-model/json_parser.py",
"demo/guide-python/external_memory.py",
"demo/guide-python/cat_in_the_dat.py",
... I am very willing to do so, let me know if it's acceptable by you and I shall change it.
|
@hcho3 @trivialfis poke. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Now the repository is much more consistent and unified, along with the linting code being cleaned up.
One minor issue mentioned in the comment, otherwise looks good to me.
I think the PR is done now, I'm pretty happy with it. |
thank you for your nice work on cleaning up the configuration and helper scripts! |
My pleasure! glad I could contribute. |
Programming Language :: Python :: 3.11
classifier for the python package.pylint
config to thepyproject.toml
and delete.pylintrc
.mypy
config to thepyproject.toml
and deletesetup.cfg
.lint_python.py
:epylint
.pyproject.toml
instead of passing them through the CLI.