Use matrix for gradient. #9508
Merged
Use matrix for gradient. #9508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivialfis
changed the title
trivialfis
changed the title
- Use the `linalg::Matrix` for storing gradients. - New API for the custom objective. - Custom objective for multi-class/multi-target is now required to return the correct shape. - Custom objective for Python can accept arrays with any strides. (row-major, column-major)
trivialfis
force-pushed
the
multi-matrix-gradient
branch
from
4e6f51d to
425d8d8
Compare
|
@rongou Would you like to help review this guy when time allows? |
|
@wbo4958 Could you please help take a look into the changes in the JVM packages? |
trivialfis
commented
Aug 23, 2023
rongou
approved these changes
Aug 23, 2023
| auto const labels_h = info.labels.HostView(); | ||
| for (size_t i = 0; i < preds_h.size(); ++i) { | ||
| bst_float w = info.GetWeight(i); | ||
| float w = info.GetWeight(i); |
There was a problem hiding this comment.
I don't have a preference, just trying to clean up some of these old types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
linalg::Matrixfor storing gradients.XGBoosterTrainOneIterfor the custom objective. Deprecating theXGBoosterBoostOneIterThe new function can be extended to irregular shape of input gradient by changing the JSON array interface into a dictionary from an array.
Close #9089 .