Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Externalize @emotion/styled to allow custom apps to own their custom theme #1354

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

syucream
Copy link
Contributor

SSIA, currently its not customizable.

…ted webpack configuration to include it as an external dependency.
@syucream syucream force-pushed the fix/externalize-emotion-styled branch from 2d02db8 to 192428d Compare January 19, 2025 01:23
@@ -1,6 +1,6 @@
{
"name": "@dmm-com/pagoda-core",
"version": "1.0.3",
"version": "1.0.4",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs to publish the new version!

Copy link
Contributor

@hinashi hinashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hinashi hinashi merged commit a41eb04 into dmm-com:master Jan 20, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants