Enable to get items considering with Alias name #1355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit update /entity/api/v2 API handler to be able to get item considering with related item.
…iesListRequest format
userlocalhost
force-pushed
the
feature/entity/api/consiering_with_alias
branch
from
b1e4122 to
1875e25
Compare
|
⚡ ⚡ ⚡ Now the latest apiv2 client npm package is available at: |
userlocalhost
force-pushed
the
feature/entity/api/consiering_with_alias
branch
2 times, most recently
from
eabd299 to
6c021b2
Compare
userlocalhost
commented
Jan 21, 2025
|
|
||
| @extend_schema( | ||
| parameters=[ | ||
| OpenApiParameter("with_alias", OpenApiTypes.STR, OpenApiParameter.QUERY), |
There was a problem hiding this comment.
It would be better to use OpenApiTypes.BOOL instead of OpenApiTypes.STR
There was a problem hiding this comment.
On second thought, OpenApiTypes.STR is better than BOOL because this is a GET parameter.
The request.query_params.get("with_alias") contains string typed value even through extend_schema configuration.
if request.query_params.get("with_alias"):
return original_fields + ["aliases__name"]
else:
return original_fieldsSo that condition would be True when user specified with_alias=false.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit update /entity/api/v2 API handler to be able to get item considering with related item.
Confirmation
I confirmed that I can get item that is related with specified alias at the alias list page.
